Update igraph from 0.6.4 to 0.7.1 #1146
Conversation
bee init https://github.com/igraph/igraph/releases/download/0.7.1/igraph-0.7.1.tar.gz git mv igraph-0.7.1-0.bee igraph.be0
-fPIC ensures that the result can also be used in foreign modules.
|
What are the default CFLAGS? Why not keep the shared library? We do not know, if some user linked against it in a personal project? |
|
The default CFLAGS are empty -> ''. The rest is set inside the Makefile. |
|
Concerning the usage of So, from now on let the people build their (python,perl,R,...) bindings from the lib-archive. |
|
For the record, please do not remove shared libraries in the future. Upstream just tests with that, and not using it makes us and our users hit corner cases, cf #1151. |
|
Sorry Paul, but you are just presenting a 'FMIW' solution. To me this reads like libigraph has a little problem (that needs checking). But it clearly doesn't mean that we now should start over with shared libs again. Right? |
|
On 06/28/19 14:19, Thomas Kreitler wrote:
Sorry Paul, but you are just presenting a 'FMIW' solution.
WFE → Works For Everybody. ;-)
After some checking I've found an error when the 'static' igraph is
imported by python (both pythons, it would have been helpfull if you
would have mentionend it)
No idea, what you mean by both Pythons.
`undefined symbol: _ZTVN10__cxxabiv117__class_type_infoE`that points
to some C++ issues (N.B. That igraph is using also c++ code is a
point I've overlooked when building libigraph, meaning the current
build is rubbish). The next test included two builds of libigraph and
testing. Whereas the version with the shared lib passed all tests,
the static-only variant happily fails:> ```
ERROR: 227 tests were run,
56 failed unexpectedly.
7 tests were skipped.
```
To me this reads like libigraph has a little problem (that needs
checking). But it clearly doesn't mean that we now should start over
with shared libs again. Right?
For me that’s the right solution, as we do not want to diverge from
how *everybody else*, especially the developers run the software.
Anyway, please let’s merge this so that our users can start using the
Python packages.
The general strategy can be discussed in person at the next Linux
teatime.
|
|
Since the currently installed libigraph.a has issues you may go ahead (maybe even rebuild with --enable-static=no ?). Also I do not opt for build 'everything' static. But as for 'everybody else', our system is not 'everybody elses single user apt update etc system' -- different story. |
|
FMIW ? |
|
FMIW -> For Me It Works |
|
Funfact beside: The igraph webpage is a bit cheeky when presenting the [download c library] grin |
|
Before some weekend efforts start... The 'problem' with the testsuite is resolved, rather trivial: throw in some more -lxyz options. |
No description provided.